Addons: Delay updating of tasks list until document has been colorised #1257
Conversation
There was a problem hiding this comment.
Perhaps get the doc pointer first and check valid, then link the tasks object lifetime to the doc (if it isn't already).
Otherwise get current doc in the callback, since tasks doesn't write to the doc it won't do any harm if it scans tasks for the visible doc, not the one initially requested so long as its re-scanned when it becomes visible.
The chances of the doc being deleted between the idle being scheduled and the callback is unlikely, but who knows what them plugins will do. Better not to use dangling pointers.
addons/src/ao_tasks.c
Outdated
| { | ||
| AoTasksUpdateTasksForDocArguments *arguments = data; | ||
| AoTasks *t = arguments->t; | ||
| GeanyDocument *doc = arguments->doc; |
There was a problem hiding this comment.
Needs to check valid since its an unknown period and unknown actions before it happens (isn't asynchronous fun!)
There was a problem hiding this comment.
I don't know if there is more than checking data for NULL. BUt at least I've added this.
There was a problem hiding this comment.
Alright, done and also in a few more places in the Addons plugin.
addons/src/ao_tasks.c
Outdated
| { | ||
| AoTasksUpdateTasksForDocArguments *arguments = data; | ||
| AoTasks *t = arguments->t; |
There was a problem hiding this comment.
Will the lifetime of AoTasks object guarantee its still valid (see below)
There was a problem hiding this comment.
I think so. The AoTasks object exists as long as the Addons plugin is loaded, independently of opened documents and independent of whether the Tasks addon is enabled or not.
While in theory possible I think it's highly unlikely that a user will manage to unload the Addons plugin or even only to quit Geany so that the AoTasks object will be destroyed while an idle callback is still waiting to be executed.
|
@elextr fine by you now? |
|
I'd like to merge this in a few days if there are no objections or further remarks. |
|
Oops, missed the changes being added, fine by me. |
Closes #1254.
This is not completely perfect but will do the trick to delay the parsing of tasks in the current document until the main loop has triggered the also delayed colourising of the current document which is necessary for parsing the tasks.