Markdown: Add support for webkit2gtk-4.1 #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGBI, the removals look good but did not check thats all that needs removing. |
|
Needs to update README |
b4n
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Looks good, works fine, but the 2 first commits don't really work one without the other, so they should be merged: the first one actually make it use webkit2gtk only, but by removes the conditional that enables the code to use it (and it probably also breaks the build system by having an undefined conditional).
So fine by me once those 2 commits get squashed together.
xiota
force-pushed
the
pr-markdown-webkit2gtk-4.1
branch
from
c8d5d22
to
a0e8192
Compare
|
@b4n Thanks... I've squashed the commits. |
b4n
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for webkit2gtk-4.1. Drop support for webkitgtk.
Still works with webkit2gtk-4.0.
Related: #1295