Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(PR): introduce new workflow PR #2959

Merged
merged 8 commits into from
Aug 8, 2023
Merged

ci(PR): introduce new workflow PR #2959

merged 8 commits into from
Aug 8, 2023

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Jul 18, 2023

Resolves #2875
Squashed the commits #2878 based on the current master branch

---
title: Usages of check and build
---

flowchart LR
PR --> check{check}
CI --> check

CI --> |macos=true| build
PR -->|already-A0-A2, macos?| build{build}
Label -->|A0| build
Label -->|E2| build
Loading
  • trigger build on new labels
    • no more rerunning everything on changing labels
  • make the workflow of PR independent

This PR contains only 4 commits with clear purposes just for making reviewing easier

commit description
6ee3af0 duplicate CI.yml that we can figure out the changes in the following commits
7703ed8 cherry-pick check and check-fuzzer steps from CI.yaml and create a new workflow check.yml
d3db8e5 cherry-pick build, build-win-cross and build-macos steps from CI.yaml and create a new workflow check.yml
3806481 introduce labels.yml and PR.yml
d077d52 merge the cache implementation in #3001, embedded it status check of PR.yml, for CI.yml, it's at its previous place

@gear-tech/dev

@clearloop clearloop force-pushed the cl/issue-2875-2 branch 2 times, most recently from bdf0f04 to 1eba943 Compare July 18, 2023 06:14
@clearloop clearloop force-pushed the cl/issue-2875-2 branch 2 times, most recently from ebe8bc4 to 1359870 Compare July 18, 2023 06:29
@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team E2-forcemacos Force CI to run macOS build in PR labels Jul 18, 2023
@clearloop clearloop changed the title ci(actions): introduce new workflow PR ci(PR): introduce new workflow PR Jul 18, 2023
@clearloop clearloop marked this pull request as ready for review July 18, 2023 07:41
@ukint-vs
Copy link
Member

image

Why there is duplicate build actions?

@ukint-vs ukint-vs added the A2-mergeoncegreen PR is ready to merge after CI passes label Jul 22, 2023
@clearloop clearloop requested review from breathx and removed request for breathx July 25, 2023 11:40
@StackOverflowExcept1on
Copy link
Member

should it be duplicated here?

- name: "CACHE: Set sccache path"
id: sccache
run: |
sccache_path="/mnt/sccache/$(echo ${GITHUB_REF#refs/heads/} | tr / _)"
echo "sccache_path=$sccache_path" >> $GITHUB_OUTPUT

we have - uses: ./.github/actions/prepare-sccache

@clearloop clearloop force-pushed the cl/issue-2875-2 branch 7 times, most recently from 4f4be5a to 1bbfab5 Compare August 3, 2023 10:41
@clearloop clearloop merged commit fdb21be into master Aug 8, 2023
7 checks passed
@clearloop clearloop deleted the cl/issue-2875-2 branch August 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes E2-forcemacos Force CI to run macOS build in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger CI only when label A0,A2 for label conditions
7 participants