Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gsdk): introduce events API #2979

Merged
merged 12 commits into from
Aug 10, 2023
Merged

feat(gsdk): introduce events API #2979

merged 12 commits into from
Aug 10, 2023

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Jul 25, 2023 •
edited
Loading

Resolves #2896

  • introduce events API
  • rename module types to subscription
  • introduce module api

@gear-tech/dev

@clearloop clearloop marked this pull request as ready for review July 26, 2023 15:34
@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Jul 26, 2023
breathx
breathx approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust some examples and write comment how it works now

gsdk/src/lib.rs Show resolved Hide resolved
gsdk/src/lib.rs Outdated Show resolved Hide resolved
gsdk/src/lib.rs Outdated Show resolved Hide resolved
gsdk/src/rpc.rs Outdated Show resolved Hide resolved
gsdk/src/signer/rpc.rs Outdated Show resolved Hide resolved
gsdk/src/subscription.rs Outdated Show resolved Hide resolved
@clearloop clearloop mentioned this pull request Aug 3, 2023
Closed
clearloop
clearloop commented Aug 3, 2023
View reviewed changes
Copy link
Contributor Author

@clearloop clearloop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR mainly added api.events() which returns an iterator gsdk::Events, which works like api.blocks()

plus, including a bench of cleaning stuffs...

gsdk/src/subscription.rs Show resolved Hide resolved
gsdk/src/api.rs Outdated Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Aug 6, 2023

@ark0f @StackOverflowExcept1on @tltsutltsu

ark0f
ark0f approved these changes Aug 10, 2023
View reviewed changes
gsdk/src/lib.rs Show resolved Hide resolved
tltsutltsu
tltsutltsu approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@tltsutltsu tltsutltsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clearloop clearloop merged commit 062a900 into master Aug 10, 2023
7 checks passed
@clearloop clearloop deleted the cl/issue-2896 branch August 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@tltsutltsu tltsutltsu tltsutltsu approved these changes

@ark0f ark0f ark0f approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce new method events for gsdk API
4 participants
@clearloop @breathx @ark0f @tltsutltsu