Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(depbot): not skipping ci #3322

Merged
merged 1 commit into from
Sep 22, 2023
Merged

chore(depbot): not skipping ci #3322

merged 1 commit into from
Sep 22, 2023

Conversation

clearloop
Copy link
Contributor

Resolves #3310

not skipping CI in the PRs of depbot

@gear-tech/dev

@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Sep 21, 2023
NikVolf
NikVolf approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@NikVolf NikVolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't it cripple our ci with many prs ?

@clearloop
Copy link
Contributor Author

won't it cripple our ci with many prs ?

yeah it is possible )))

@NikVolf
Copy link
Member

NikVolf commented Sep 21, 2023

won't it cripple our ci with many prs ?

yeah it is possible )))

i think those updates can be batched

@shamilsan
Copy link
Contributor

i think those updates can be batched

They are batched here: https://github.com/gear-tech/gear/blob/master/.github/workflows/combined-dependabot.yml

@shamilsan shamilsan merged commit 23ccf19 into master Sep 22, 2023
16 checks passed
@shamilsan shamilsan deleted the cl/issue-3310 branch September 22, 2023 06:41
@clearloop
Copy link
Contributor Author

clearloop commented Sep 23, 2023 •
edited
Loading

what if we [skip-ci] for dependabot's PRs and run full actions in the combined PR?

#3345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackOverflowExcept1on StackOverflowExcept1on StackOverflowExcept1on approved these changes

@NikVolf NikVolf NikVolf approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not skipping CI in dependency updates
4 participants
@clearloop @NikVolf @shamilsan @StackOverflowExcept1on