-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wasm-builder): allow building with stable toolchain #3459
Conversation
plz provide a test of stable build with test-program btw https://github.com/gear-tech/gear/tree/master/utils/wasm-builder/test-program mb override the rust-toolchain of this crate or using environment to do the test |
We have smoke tests in https://github.com/gear-tech/gear/blob/master/utils/wasm-builder/tests/smoke.rs but it's marked with ignored to do not waste time on I think we can test this program with both toolchains in For the gear/.github/workflows/check.yml Lines 61 to 62 in a34fcfc
|
yeah, add this pls |
|
@clearloop I think we shouldn't use |
@ark0f please take a look |
Will be continued after #3527 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StackOverflowExcept1on @ark0f @breathx
Relates #3527 (review)
# Wasm builder changes
# Use the same toolchain: `gear_wasm_builder::build::<Metadata>();`
# Use recommended nightly: `gear_wasm_builder::recommended_nightly::<Metadata>();` // ERROR IF VERSION IS DIFFERENT
Co-authored-by: Dmitry Novikov <novikov.dm.al@gmail.com>
This PR fixes build with
+stable
Tests:
@gear-tech/dev