Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(demo-constructor): Support multiple calls in if_else #3487

Merged
merged 13 commits into from
Dec 3, 2023
Merged

feat(demo-constructor): Support multiple calls in if_else #3487

merged 13 commits into from
Dec 3, 2023

Conversation

mqxf
Copy link
Contributor

@mqxf mqxf commented Nov 9, 2023

@reviewer-or-team

breathx
breathx requested changes Nov 10, 2023
View reviewed changes
examples/constructor/src/call.rs Show resolved Hide resolved
examples/constructor/src/builder.rs Show resolved Hide resolved
examples/constructor/src/call.rs Outdated Show resolved Hide resolved
examples/constructor/src/call.rs Show resolved Hide resolved
@breathx breathx added the A0-pleasereview PR is ready to be reviewed by the team label Nov 10, 2023
@breathx
Copy link
Member

breathx commented Nov 10, 2023

Once more, to run CI set the label A0-pleasereview and only then push commits

mqxf and others added 2 commits November 10, 2023 12:36
@mqxf @breathx
Update examples/constructor/src/call.rs
9c1c773 
Co-authored-by: Dmitry Novikov <novikov.dm.al@gmail.com>
@mqxf @breathx
Update examples/constructor/src/call.rs
ea7cd89 
Co-authored-by: Dmitry Novikov <novikov.dm.al@gmail.com>
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 10, 2023
mqxf and others added 3 commits November 10, 2023 13:36
@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Nov 10, 2023
@mqxf mqxf requested a review from breathx November 14, 2023 08:52
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 14, 2023
@mqxf mqxf mentioned this pull request Nov 27, 2023
Closed
@mqxf mqxf added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Nov 27, 2023
@mqxf mqxf requested a review from techraed November 29, 2023 08:33
@mqxf mqxf mentioned this pull request Nov 29, 2023
Closed
breathx
breathx approved these changes Dec 2, 2023
View reviewed changes
pallets/gear/src/tests.rs Show resolved Hide resolved
examples/constructor/src/call.rs Show resolved Hide resolved
examples/constructor/src/call.rs Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Dec 2, 2023

@SabaunT please review once more

@techraed
Copy link
Member

techraed commented Dec 2, 2023

@SabaunT please review once more

If tests continue to be in pallet, I suggest calling gr_exit instead of checking the result of "if-else" with the wait.

@techraed
Copy link
Member

techraed commented Dec 2, 2023

@mqxf it's your choice actually whether to leave the test in pallet, or to move to constructor crate.

@mqxf mqxf added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Dec 3, 2023
@mqxf mqxf merged commit 162cec1 into master Dec 3, 2023
18 checks passed
@mqxf mqxf deleted the ms/demo-constructor branch December 3, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techraed techraed techraed left review comments

@breathx breathx breathx approved these changes

@clearloop clearloop clearloop approved these changes

Assignees
No one assigned
Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mqxf @breathx @techraed @clearloop