Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crates-io): publish gtest on crates.io #3594

Merged
merged 45 commits into from
Jan 12, 2024
Merged

feat(crates-io): publish gtest on crates.io #3594

merged 45 commits into from
Jan 12, 2024

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Dec 15, 2023 •
edited by breathx
Loading

Tip

gtest-v1.0.4 is now available on crates.io based on c815950

Resolves #3501

  • publish gear-sandbox-*
    • publish -env
    • publish -host
    • publish sandbox
  • publish gear-lazy-pages
  • publish gear-core-backend
  • publish core-processor
  • publish gtest

Significant changes have been split into

Merging this PR could take some time, bcz we are about to upgrade to substrate-v1.0.0 in v1.0.4 (#3608) which will break part of the logic in the current implementation immediately, see the patch handler of substrate for the details

continue this PR after v1.0.4

see the tip on the top of this comment

@gear-tech/dev

@clearloop
Copy link
Contributor Author

now have bugs publishing sandbox-*, because the versioning of sp-wasm-interface is messed up since we have modified a log in our fork, #3603 cleans it in sandbox

@clearloop clearloop added the A5-dontmerge PR should not be merged yet label Dec 26, 2023
@clearloop clearloop mentioned this pull request Dec 27, 2023
Merged
4 tasks
@clearloop clearloop marked this pull request as ready for review December 27, 2023 08:38
@clearloop clearloop mentioned this pull request Dec 28, 2023
Merged
@breathx
Copy link
Member

breathx commented Jan 5, 2024

v1.0.4 is in master

@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team and removed A5-dontmerge PR should not be merged yet labels Jan 9, 2024
breathx
breathx approved these changes Jan 10, 2024
View reviewed changes
utils/crates-io/src/version.rs Outdated Show resolved Hide resolved
utils/crates-io/src/handler.rs Show resolved Hide resolved
utils/crates-io/src/handler.rs Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Jan 12, 2024

kindly asking @shamilsan for review
and if it's done from your side @clearloop feel free to merge

@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Jan 12, 2024
shamilsan
shamilsan approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

gtest/Cargo.toml Outdated Show resolved Hide resolved
@clearloop clearloop merged commit af1e6b8 into master Jan 12, 2024
11 checks passed
@clearloop clearloop deleted the cl/issue-3501 branch January 12, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukint-vs ukint-vs ukint-vs approved these changes

@breathx breathx breathx approved these changes

@shamilsan shamilsan shamilsan approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out a solution for publishing gtest
4 participants
@clearloop @breathx @shamilsan @ukint-vs