fix(rpc-calls): Calculate gas for empty accounts #3653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
Sometimes it happened that user couldn't calculate if his balance is zero. Especially it caused vouchers consumers.
This was happening despite the fact that the balance is mocked to suit the requirements of the call.
Bug mechanic
In order to increase accuracy of required gas measurement, the measurement is done twice:
It happened that minimal limit (in gas) can has value equivalent less than existential deposit, so our balance mocking using deposit_creating occurred no-op.
Bug fix
Always add up existential deposit in calculate gas rpc call balance mock.
NOTE: Minor refactoring is done as well