Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(workspace): Use hard pin to gear-dlmalloc #3656

Closed
wants to merge 1 commit into from
Closed

refactor(workspace): Use hard pin to gear-dlmalloc #3656

wants to merge 1 commit into from

Conversation

breathx
Copy link
Member

@breathx breathx commented Jan 12, 2024

Inspired by the fear of poorly held semver in future

@breathx breathx added A0-pleasereview PR is ready to be reviewed by the team P4-consider Lowest priority labels Jan 12, 2024
@breathx breathx changed the title refactor(workspace): Use hard pin to dlmalloc fork refactor(workspace): Use hard pin to gear-dlmalloc Jan 12, 2024
@shamilsan
Copy link
Contributor

It is better to respect semver instead of pinning the dep's version.

@NikVolf
Copy link
Member

NikVolf commented Jan 12, 2024

yeah generally unless dependency is known to violate this, better avoid

@breathx
Copy link
Member Author

breathx commented Jan 12, 2024

Won't be applied

@breathx breathx closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team P4-consider Lowest priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breathx @shamilsan @NikVolf