Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(PR): manage validator checks in PR.yml #3767

Merged
merged 17 commits into from
Mar 20, 2024
Merged

ci(PR): manage validator checks in PR.yml #3767

merged 17 commits into from
Mar 20, 2024

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Feb 29, 2024 •
edited
Loading

Resolves #3765
Closes #3820

triggers validator-checks inside of PR.yml in case of creating empty check suite in github UI

@gear-tech/dev

@clearloop clearloop added the check-validator Build binary and validate on 8 vara validator label Feb 29, 2024
@clearloop clearloop marked this pull request as ready for review February 29, 2024 12:04
@clearloop clearloop added the A4-insubstantial Not too important PR label Feb 29, 2024
@clearloop clearloop mentioned this pull request Feb 29, 2024
Merged
2 tasks
@clearloop clearloop mentioned this pull request Mar 12, 2024
Merged
breathx
breathx approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please actualise PR according to #3616 from master

Otherwise lgtm

@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Mar 13, 2024
@breathx
Copy link
Member

breathx commented Mar 19, 2024

whats wrong with workflow? should be fixed?

@clearloop clearloop mentioned this pull request Mar 19, 2024
Merged
@clearloop
Copy link
Contributor Author

clearloop commented Mar 19, 2024 •
edited
Loading

whats wrong with workflow? should be fixed?

interesting, no logic changes in this workflow, only 5 PRs(including the current one) labeled check-validators in history, but the other most recently one #3801 seems working with it perfectly

clearloop
clearloop commented Mar 19, 2024
View reviewed changes
.github/workflows/PR.yml Outdated Show resolved Hide resolved
@clearloop clearloop requested a review from breathx March 20, 2024 15:47
@clearloop clearloop requested a review from ark0f March 20, 2024 16:12
@clearloop clearloop merged commit 7c32cf7 into master Mar 20, 2024
12 checks passed
@clearloop clearloop deleted the cl/issue-3765 branch March 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ark0f ark0f ark0f approved these changes

@sergeyfilyanin sergeyfilyanin Awaiting requested review from sergeyfilyanin

@StackOverflowExcept1on StackOverflowExcept1on Awaiting requested review from StackOverflowExcept1on

@breathx breathx Awaiting requested review from breathx

Assignees
No one assigned
Labels
A2-mergeoncegreen PR is ready to merge after CI passes A4-insubstantial Not too important PR check-validator Build binary and validate on 8 vara validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger live checks on workflow level
3 participants
@clearloop @breathx @ark0f