Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm-builder): Test features tracking #3822

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Mar 19, 2024

Also skip WASM compilation during Intellij project sync because Intellij itself cannot yet.

Actually this was attempt to get rid of constant build script re-run :/

Idea was to use CARGO_FEATURE_* environment variables listing (cargo_metadata) and tracking (cargo:rerun-if-env-changed) but:

Note that the environment variables here are intended for global environment variables like CC and such, it is not possible to use this for environment variables like TARGET that Cargo sets for build scripts. The environment variables in use are those received by cargo invocations, not those received by the executable of the build script.

@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team D4-test Autotests, and examples labels Mar 19, 2024
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Mar 20, 2024
utils/wasm-builder/tests/smoke.rs Outdated Show resolved Hide resolved
utils/wasm-builder/tests/smoke.rs Show resolved Hide resolved
ark0f and others added 2 commits March 20, 2024 20:24
Co-authored-by: clearloop <tianyi.gc@gmail.com>
Co-authored-by: clearloop <tianyi.gc@gmail.com>
@ark0f ark0f merged commit 37c247e into master Mar 21, 2024
12 checks passed
@ark0f ark0f deleted the al/wasm-builder-features branch March 21, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes D4-test Autotests, and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants