Heuristics tests are altered to panic with multiple results #4252
Conversation
runtime/vara/src/tests.rs
Outdated
| pub parachain_read_heuristic: CostOf<GearPagesAmount>, | ||
| } | ||
|
|
||
| impl<T: pallet_gear::Config> From<MemoryWeights<T>> for PagesCosts { |
There was a problem hiding this comment.
btw we already have gear_core::costs::LazyPagesCosts. mb reuse it here?
gear/pallets/gear/src/schedule.rs
Line 1304 in 73929e3
There was a problem hiding this comment.
we could add the missing fields (from MemoryWeights<T>) to gear_core::costs::LazyPagesCosts and reuse that for both gtest and these checks.
There was a problem hiding this comment.
That way LazyPagesCosts become not actually costs of lazy pages. wdyt @grishasobol ?
There was a problem hiding this comment.
Do you think we need a more generic name for the structure? @breathx
runtime/vara/src/tests.rs
Outdated
| }; | ||
| } | ||
|
|
||
| let expectations = vec
…-improve-ux-of-runtime-heuristics-tests
…-improve-ux-of-runtime-heuristics-tests
Lazark0x
added
A0-pleasereview
| use sp_runtime::AccountId32; | ||
|
|
||
| #[cfg(feature = "dev")] | ||
| use frame_support::traits::StorageInstance; |
There was a problem hiding this comment.
pls move everything into module. runtime/vara/tests is general testing module. so all "utils" like `WeightExpectation' should be somewhere else. keep here tests only
…-improve-ux-of-runtime-heuristics-tests
Resolves #4246