Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sandbox-host): update sandbox host wasmi version #4282

Merged
merged 40 commits into from
Nov 4, 2024

Conversation

ByteNacked
Copy link
Member

@ByteNacked ByteNacked commented Oct 8, 2024

Resolves #3017 .

  • Update Wasmi host executor version
  • Update lazy-pages-fuzzer Wasmi version
  • Add CLI parameters to switch host executor
  • Sync mainnet
  • Sync testnet

@reviewer-or-team

@ByteNacked ByteNacked added the A5-dontmerge PR should not be merged yet label Oct 8, 2024
@ByteNacked ByteNacked self-assigned this Oct 8, 2024
@ByteNacked ByteNacked marked this pull request as draft October 8, 2024 09:19
@ByteNacked ByteNacked force-pushed the rmasl-update-sandbox-wasmi-version branch from 40c5eea to 6975f42 Compare October 14, 2024 18:26
@ByteNacked ByteNacked marked this pull request as ready for review October 15, 2024 08:35
@ByteNacked ByteNacked requested review from breathx, gshep and ark0f and removed request for breathx October 15, 2024 08:37
@ByteNacked ByteNacked requested a review from ark0f October 23, 2024 14:02
Copy link
Member

@ark0f ark0f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sandbox/host/src/sandbox/wasmi_backend.rs Outdated Show resolved Hide resolved
@ByteNacked ByteNacked added A3-gotissues PR occurred to have issues after the review A5-dontmerge PR should not be merged yet labels Oct 25, 2024
@ByteNacked
Copy link
Member Author

ByteNacked commented Oct 25, 2024

🛑 Seems Wasmi executor unable to sync testnet, gonna investigate this problem.

Update: Fixed ✔️ ✔️

@ByteNacked ByteNacked removed A3-gotissues PR occurred to have issues after the review A5-dontmerge PR should not be merged yet labels Oct 29, 2024
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we init sandbox for ethexe as it used to be?

@ByteNacked
Copy link
Member Author

ByteNacked commented Nov 4, 2024

should we init sandbox for ethexe as it used to be?

No we're not, init only sets global sandbox type.
added comment:

// Sets the global sandbox backend type.
// Buy default, it's set to `Wasmer`, so in case of `Wasmer` it's not necessary to call this function.
pub fn init(sandbox_backend: sandbox_env::SandboxBackend) {

@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 4, 2024
@breathx breathx merged commit 6eab909 into master Nov 4, 2024
11 checks passed
@breathx breathx deleted the rmasl-update-sandbox-wasmi-version branch November 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes C1-feature Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update wasmi host executor
4 participants