refactor(core): commit family of syscalls does not keep state between executions #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breathx
requested changes
Nov 5, 2024
| None, | ||
| Some("STORED COMMON"), | ||
| Some("STORED REPLY"), | ||
| // payload is not kept between executions so we get a panic here |
There was a problem hiding this comment.
tests for dedicated functionality should be removed
| @@ -814,18 +814,13 @@ mod tests { | |||
| Error::OutgoingMessagesBytesLimitExceeded, | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| /* #[test] | |||
| @@ -583,7 +582,8 @@ impl MessageContext { | |||
| } | |||
|
|
|||
| /// Destructs context after execution and returns provided outcome and store. | |||
| pub fn drain(self) -> (ContextOutcome, ContextStore) { | |||
| pub fn drain(mut self) -> (ContextOutcome, ContextStore) { | |||
| self.store.local_nonce += self.tmp_store.outgoing.len() as u32; | |||
There was a problem hiding this comment.
that's kind of dangerous, since we could adjust local nonce on each access, so I'd go this way
| Some(Some(data)) => data, | ||
| Some(None) => return Err(Error::LateAccess), | ||
| None => return Err(Error::OutOfBounds), | ||
| None => { | ||
| // debug!("OOB: {:#?}", backtrace::Backtrace::new().frames()); |
| @@ -141,33 +141,39 @@ impl ContextOutcome { | |||
| } | |||
| } | |||
| } | |||
| /// Store of current temporary message execution context. | |||
| #[derive(Clone, Default, Debug, Eq, Hash, Ord, PartialEq, PartialOrd, Decode, Encode, TypeInfo)] | |||
| pub struct TmpStore { | |||
There was a problem hiding this comment.
I'd consider other naming options. Could be "Payloads" or something like that
|
Otherwise, lgtm |
breathx
added
A3-gotissues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR based on #4288 but with cleaner code and solution that does not break a fuzzer. Still WIP but all that is left is write a migration and fix tests.
@breathx