Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gclient): removed filtering static pages while creating memory dump #4319

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Lazark0x
Copy link
Member

Resolves #3893

@Lazark0x Lazark0x added the A0-pleasereview PR is ready to be reviewed by the team label Oct 31, 2024
@Lazark0x Lazark0x requested a review from breathx October 31, 2024 18:05
@Lazark0x Lazark0x self-assigned this Oct 31, 2024
gclient/tests/memory_dump.rs Outdated Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 4, 2024
@breathx
Copy link
Member

breathx commented Nov 5, 2024

@Lazark0x need to figure out whats happening with CI here

@breathx breathx merged commit d43076a into master Nov 5, 2024
12 checks passed
@breathx breathx deleted the laz/3893-save-program-dump-static-pages-also branch November 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save_program_memory_dump_at must dump static pages also
3 participants