Implement parser and typescript code generator #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipov-mit
requested review from
NikVolf,
DennisInSky,
LouiseMedova and
nikitayutanov
|
I would've called directory |
nikitayutanov
approved these changes
Dec 7, 2023
DennisInSky
reviewed
Dec 26, 2023
There was a problem hiding this comment.
I've left some comments along the code, but actually the main comment is that didn't we want to have our parser to be a wasm allowing it to be re-used from other languages? As such wouldn't it be better to use rust for implementing it then? I checked candid and they use logos as lexer in conjunction with larlpop as parser for building AST
@NikVolf , @osipov-mit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.