chore(js): setup release flow #608
Conversation
osipov-mit
requested review from
Zewasik and
DennisInSky
and removed request for
Zewasik
js/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Why do you want this to be persisted in SCM and not generated by initiating a release via GH?
There was a problem hiding this comment.
It's just more customisable and I see no reason to include all commits not related to the js part
| @@ -0,0 +1,77 @@ | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
I thought you wanted to support the release trigger. Do you want to release on every merge into master regardless of changes?
There was a problem hiding this comment.
Updated. The release will only be triggered on commits affecting root package.json and there is a step that checks if the version has been changed
js/parser/parser.wasm
Outdated
There was a problem hiding this comment.
Shouldn't we publish this binary as an artifact of a RS release?
There was a problem hiding this comment.
Yes!
I will change the behaviour when it's done
| if: env.skip != 'true' | ||
| run: | | ||
| git tag ${{ env.TAG_NAME }} | ||
| git push origin ${{ env.TAG_NAME }} |
There was a problem hiding this comment.
Don't you want to do at the very last point? Does the next action require the tag to exist?
There was a problem hiding this comment.
It's actually used in the very next step.
No description provided.