Added Spanish Language support #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now I think we can use the approach whereby we use gem.db3 in strings.xml. I will update issue #19 based on these changes. I see that there are many files which have no content changes but which have changed permissions (from 644 to 755) - could I ask you to please remove execute permission from the files README.md, LICENSE.txt, all html files, etc. and to renew this pull request - this way we see only the files that have really changed. Thanks. |
|
Hello, I am doing so. Permissions has been fixed. I pushed this to the new branch you created, so I am sending another pull-request from the 'spanish' branch in the corposso account. |
|
Closing this PR - replaced by PR #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version add strings variables in two languages (English and Spanish) into all the layouts in order to change the application language depending on the language configured in the device. For the application data two databases were used, one for each language.
By using two databases a problem arises if a person start the application in a language and after switch the device to the another one. Therefore, this approach will always load the Spanish Language database version for avoid any data loss risk, also considering this application version was intended to Spanish speakers.
This behavior can be modified changing in app/src/main/res/values/strings.xml:
gem-es.db3
to
gem.db3