Add initial thorchain implementation #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xh3rman
reviewed
Nov 7, 2024
0xh3rman
reviewed
Nov 7, 2024
| } | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| pub struct QuoteFees {} |
There was a problem hiding this comment.
We need to return total fees into the result quote
| request.clone().from_asset, | ||
| request.to_asset.clone(), | ||
| value.to_string(), | ||
| "g1".to_string(), |
There was a problem hiding this comment.
let's add a constant for this g1
| @@ -15,6 +15,11 @@ impl BigNumberFormatter { | |||
| let decimal = Self::big_decimal_value(value, decimals as u32)?; | |||
| Some(decimal.to_string()) | |||
| } | |||
|
|
|||
| pub fn divide(value: &str, decimals: u32) -> String { | |||
There was a problem hiding this comment.
maybe pass in BigInt instead of str, then we can handle unwrap outside
0xh3rman
reviewed
Nov 7, 2024
| } | ||
|
|
||
| async fn fetch_quote_data(&self, quote: &SwapQuote, _provider: Arc<dyn AlienProvider>, _data: FetchQuoteData) -> Result<SwapQuoteData, SwapperError> { | ||
| let memo = ThorChainSwapClient::get_memo(quote.request.to_asset.clone(), quote.request.destination_address.clone(), "g1".to_string(), 50).unwrap(); |
0xh3rman
reviewed
Nov 7, 2024
| provider: SwapProviderData { | ||
| name: self.name().to_string(), | ||
| routes: vec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.