-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags currency #32
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
89ece9f
Add flags to each currency #14 https://github.com/gemwalletcom/gem-io…
gemdev111 f0cbeb6
Add flags to each currency #14 https://github.com/gemwalletcom/gem-i…
gemdev111 e91e6b3
[-] removed unused optional unwrapping with empty string
gemdev111 86255ad
Merge branch 'main'
gemdev111 d70426b
[f] xcode pbproj fixes
gemdev111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
GemTests/Settings/ViewModels/CurrencySceneViewModelTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import XCTest | ||
import Primitives | ||
@testable import Gem | ||
|
||
final class CurrencySceneViewModelTests: XCTestCase { | ||
func testCurrencyText() { | ||
let usdCurrency = CurrencySceneViewModelTests.nativeCurrency(currency: .usd) | ||
|
||
let usdCurrencyTitle = usdCurrency?.title | ||
let mockUsdCurrencyTitle = "🇺🇸 USD - US Dollar" | ||
XCTAssertEqual(usdCurrencyTitle, mockUsdCurrencyTitle) | ||
|
||
let uahCurrency = CurrencySceneViewModelTests.nativeCurrency(identifier: "UAH") | ||
let uahCurrencyTitle = uahCurrency?.title | ||
|
||
let mockUAHCurrencyTitle = "🇺🇦 UAH - Ukrainian Hryvnia" | ||
XCTAssertEqual(uahCurrencyTitle, mockUAHCurrencyTitle) | ||
} | ||
|
||
func testCurrencyTextWithXDREmojiFlag() { | ||
let xdrCurrency = CurrencySceneViewModelTests.nativeCurrency(identifier: "XDR") | ||
let xdrCurrencyTitle = xdrCurrency?.title | ||
|
||
let mockXdrCurrencyTitle = "🏳️ XDR - Special Drawing Rights" | ||
XCTAssertEqual(xdrCurrencyTitle, mockXdrCurrencyTitle) | ||
} | ||
|
||
func testUnknownCurrency() { | ||
let unknownCurrency = CurrencySceneViewModelTests.nativeCurrency(identifier: "XYZ") | ||
let unknownCurrencyTitle = unknownCurrency?.title | ||
|
||
// unknown currency not supported, it's managed by Currency raw vlaue from primitives | ||
XCTAssertEqual(unknownCurrencyTitle, nil) | ||
} | ||
|
||
func testBitcoinCurrency() { | ||
let btcCurrency = CurrencySceneViewModelTests.nativeCurrency(identifier: "BTC") | ||
let btcCurrencyTitle = btcCurrency?.title | ||
|
||
/* not supported yet | ||
let mockBtcCurrencyTitle = "₿ BTC - Bitcoin" | ||
XCTAssertEqual(btcCurrencyTitle, mockBtcCurrencyTitle) | ||
*/ | ||
XCTAssertEqual(btcCurrencyTitle, nil) | ||
} | ||
} | ||
|
||
extension CurrencySceneViewModelTests { | ||
static func nativeCurrency(identifier: String.ID) -> Locale.Currency? { | ||
Currency.nativeCurrencies.first(where: { $0.identifier == identifier }) | ||
} | ||
|
||
static func nativeCurrency(currency: Currency) -> Locale.Currency? { | ||
Currency.nativeCurrencies.first(where: { $0.identifier == currency.rawValue }) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add unit test for this one? to make sure we properly present the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add