Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet list delete confirmation #54

Merged
merged 25 commits into from
Jun 13, 2024
Merged

Wallet list delete confirmation #54

merged 25 commits into from
Jun 13, 2024

Conversation

gemdev111
Copy link
Contributor

#49 Done

@gemdev111
Refactored BuyAssetScene logic to support state button
ca46a66 
added view state, removed bipolared code
added input mode
updated body to separate components
updated AddTokenViewModel & WalletScene to support default input for BuyAssetScene
updated FiatProvidersViewModel to support buyAsset input
@gemdev111
ButtonStyle refactored, updated gem dependecies with new buttonstyle api
43c6281
@gemdev111
Moved Colors assets to Style package
d29d0c4 
Removed unsued mocked previews
created BundleFinder for Styles, added Tests to StyleBundle
@gemdev111
Added previews for colors
5628f66
@gemdev111
removed unused comments from TextStle
4615815
@gemdev111
Added State Button
a9cde63 
Added new state style for button style
Updated previews for colors, system image, button style, state empty view => using List now
Updates in BuyAssetScene & BuyAssetViewModel to support state button
@gemdev111
Merge branch 'main' into state-button
0e7ce4c
@gemdev111
Git submodules refreshed, added new. Done #12
e43f35e
@gemdev111
Merge branch 'main' into state-button
177c2c9
@gemdev111
git submodule updates
9ffabdb
@gemdev111
Removed unused StyleBundleTests
643beb0
@gemdev111
Added neccesary extensions like if, iflet for esier SwiftUI body mana…
6c6f4e2 
…gement

and confirmation dialog wrapper to SwiftUIView extensions
@gemdev111
Minor Updates WalletDetailViewModel
308069e 
Added delete button to WalletDetailsScene + confirmation, minor refactor
@gemdev111
added necessary dismiss after deleting current wallet
b617b90
@gemdev111
Merge branch 'wallet-screen-confirmation'
2a271d3
@gemdev111
Added delete wallet confirmation, in swipe actions and in context menu
e6d5564
@gemdev111
Refactored WalletsScene & WalletsViewModel a bit
e649883 
Fixed multiple dismiss on wallet select
@gemdev111
Removed unused comments
0aaf773
@gemdev111
github CI not compatible with swift code style, possible fix
9490155
@gemdev111
Merge branch 'main' into wallet-screen-confirmation
72a00d4
@gemdev111
added delete button style as apple uses in general delete behaviour
def7a48 
updated button style in WalletDetailScene
@gemdev111
Merge branch 'wallet-screen-confirmation'
9b60773
@gemdev111 gemdev111 linked an issue Jun 13, 2024 that may be closed by this pull request
Add delete confirmation on wallets screen #49
Closed
@gemdev111 gemdev111 merged commit 11e97d9 into main Jun 13, 2024
1 check passed
@gemdev111 gemdev111 deleted the wallet-list-delete-confirmation branch June 13, 2024 17:58
@gemdev111 gemdev111 linked an issue Jun 13, 2024 that may be closed by this pull request
Add delete action on Wallet Detail screen #50
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemcoder21 gemcoder21 gemcoder21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delete action on Wallet Detail screen Add delete confirmation on wallets screen
2 participants
@gemdev111 @gemcoder21