build(linter): fix makezero linter issue (hybridgroup#965)

gen2thomas · Jul 6, 2023 · a6d6571 · a6d6571
1 parent bc3d7d4
commit a6d6571
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -32,7 +32,7 @@ linters:
   # currently active linters:
   #
   #INFO [lintersdb] Active 35 linters: [asasalint asciicheck bidichk contextcheck decorder depguard durationcheck errcheck exportloopref
-  # gocheckcompilerdirectives gomoddirectives gomodguard goprintffuncname gosimple govet grouper ineffassign mirror musttag
+  # gocheckcompilerdirectives gomoddirectives gomodguard goprintffuncname gosimple govet grouper ineffassign makezero mirror musttag
   # nilerr nilnil nolintlint nosprintfhostport prealloc reassign revive staticcheck tagalign tenv testableexamples tparallel typecheck unused wastedassign]
 
   enable-all: true
@@ -74,7 +74,6 @@ linters:
     - zerologlint # not needed (related to zerolog package)
     # important to have
     - gofmt # important to prevent "format tsunami" ("gofmt -s -w" missed), disabled due to "https://github.com/golangci/golangci-lint-action/issues/535"
-    - makezero # very important (find/reduce bugs, e.g. in robot_work_test.go)
     - nakedret # very useful together with "nonamedreturns" (reduce bugs)
     - nonamedreturns # very useful (reduce bugs)
     - unconvert # very useful (reduce bugs, simplify code)

diff --git a/robot_work_test.go b/robot_work_test.go
@@ -94,8 +94,10 @@ func TestRobotAutomationFunctions(t *testing.T) {
 
 func collectStringKeysFromWorkRegistry(rwr *RobotWorkRegistry) []string {
 	keys := make([]string, len(rwr.r))
-	for k := range rwr.r {
-		keys = append(keys, k)
+	var idx int
+	for key := range rwr.r {
+		keys[idx] = key
+		idx++
 	}
 	return keys
 }