Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMID search returns correct model but doesn't show the PMID in the table #15

Open
vanaukenk opened this issue May 30, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@vanaukenk
Copy link

I tested searching for PMID:12186849.

The search returns four correct models, but when I open the last model in the list 'C. elegans PDI-2 pathway', I don't see that PMID listed as evidence for any of the annotations.

The other three models do show that PMID listed in the table.

@vanaukenk vanaukenk added the bug Something isn't working label May 31, 2019
@tmushayahama
Copy link
Collaborator

PMID:12186849 is there in the model,

below is a quick way I found out from the row data
image

Now as to why, these are the potentials. will debug soon

  • The model has an error (2 part ofs), so one of them was read
  • if the evidence was a causal edge linking activities
  • the other triple is not really an activity
  • A rare case is an orphan evidence. @kltm @vanaukenk some of the models have these dangling evidences, maybe we need to cleanup, if you go to graph editor and explode all out view

@tmushayahama
Copy link
Collaborator

tmushayahama commented May 31, 2019

Found the error

If you open the model in graph editor, this is where the PMID:12186849 is

image

the reason is the model has more than one part of on protein disulfide isomerase activity.

@vanaukenk
Copy link
Author

Thanks @tmushayahama
We should consult with @thomaspd wrt the two 'part of' relations.
In theory, one MF could be a sub-function of another and curators could use the 'part of' relation between them, but we don't have that modeled in the Noctua form, yet.

@tmushayahama
Copy link
Collaborator

@vanaukenk @lpalbou This is still an issue. but this might be a ticket for landing page.

But the second part of the issue is with ART is that Noctua Form doesn't truly represent a noctua model. So in this case, do I replace what NF is seeing, has parsed or what the model has.

As an example let's say an reference on a "directly provides input for" or any edge or info NF doesn't read or sub functions
image

@vanaukenk
Copy link
Author

@tmushayahama
Let me review these models again and get back to you. We may need to split this out into separate tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants