Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved parser Performance #3

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Improved parser Performance #3

merged 1 commit into from
Oct 15, 2023

Conversation

generalpy101
Copy link
Owner

Main changes were reducing number of splits and directly do byte parsing instead of string parsing. Not a very huge improvement in performance but can see results after change:
eg:
After change

$ redis-benchmark -p 9999 -t SET,GET -q
WARNING: Could not fetch server CONFIG
SET: 14440.43 requests per second, p50=3.247 msec
GET: 14587.89 requests per second, p50=3.247 msec

Before change

$ redis-benchmark -p 9999 -t SET,GET -q
WARNING: Could not fetch server CONFIG
SET: 13415.62 requests per second, p50=3.487 msec
GET: 13956.73 requests per second, p50=3.407 msec

@generalpy101 generalpy101 merged commit 9a7a417 into main Oct 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant