Add support for predictions app #364
Conversation
src/resdk/query.py
Outdated
| if missing: | ||
| # Get corresponding annotation field details in a single query and attach it to | ||
| # the values. | ||
| for field in self.resolwe.prediction_field.filter(id__in=missing.keys()): |
There was a problem hiding this comment.
Use .iterate() to make it more robust.
There was a problem hiding this comment.
Done. Also on annotation values.
| Sample: "sample", | ||
| Relation: "relation", | ||
| Process: "process", | ||
| Data: "data", |
There was a problem hiding this comment.
This reordering should go into a separate commit.
gregorjerse
force-pushed
the
feature/predictions
branch
3 times, most recently
from
cd4a4d1
to
fe687a5
Compare
gregorjerse
force-pushed
the
feature/predictions
branch
2 times, most recently
from
5d17b5a
to
2736e71
Compare
to make AnnotationValueQuery more robust
gregorjerse
force-pushed
the
feature/predictions
branch
from
2736e71
to
39a69ba
Compare
| missing[value.field_id].append(value) | ||
|
|
||
| if missing: | ||
| # Get corresponding annotation field details in a single query and attach it to |
There was a problem hiding this comment.
Get corresponding prediction field details...
|
|
||
| @property | ||
| @assert_object_exists | ||
| def modified(self): |
There was a problem hiding this comment.
This might be nitpicking, but why do we display modified for the value of created? Is there a simple explanation for this? AFAIK PredictionValues should not be modified, only new "versions" created? In this case, it would be more intuitive, to just expose this as created, and not expose the modified property at all?
There was a problem hiding this comment.
Since it is actually the modification date from the user perspective.
When new prediction / annotation is created (that overrides the old one) it can be seen as a modification of an old value. Not sure what is the correct way of handling this, I can also just leave created field and remove modified.
No description provided.