Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Openapi #1417

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

WIP: Openapi #1417

wants to merge 15 commits into from

Conversation

plyhun
Copy link
Contributor

@plyhun plyhun commented Jul 11, 2022

Abstract

Serve OpenAPI YAMS / JSON schema requests.

Checklist

General

  • Added abstract that describes the change
  • Added changelog entry to /CHANGELOG.adoc
  • Ensured that the change is covered by tests
  • Ensured that the change is documented in the docs

On API Changes

  • Checked if the changes are breaking or not
  • Added GraphQL API if applicable
  • Added Elasticsearch mapping if applicable

@plyhun plyhun changed the title Openapi WIP: Openapi Jul 20, 2022
@plyhun
Copy link
Contributor Author

plyhun commented Jul 20, 2022

Tests missing here.

plyhun
plyhun commented Jun 11, 2024
View reviewed changes
core/src/main/java/com/gentics/mesh/core/endpoint/RolePermissionHandlingEndpoint.java
@@ -77,5 +78,21 @@ protected void addRolePermissionHandler(String uuidParameterName, String uuidPar
String uuid = rc.request().getParam(uuidParameterName);
crudHandler.handleRevokePermissions(ac, uuid);
});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP standard has no directions over DELETE methods with body, so the client generator fails on the method above, as not following the standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npomaroli npomaroli npomaroli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plyhun @npomaroli