Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: switch the python checker CI to use something that is maintained #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jan 7, 2024

  1. github: switch the python checker CI to use something that is maintained

    The python-lint action was last updated 3 years ago. It contains very
    old versions of the lint tools, including pre-1.0 versions of mypy. It
    doesn't allow installing dependencies for mypy to robustly typecheck.
    
    Simply installing the tools ourselves and running them directly is
    simpler, shorter, easier, and provides better linting analysis. So, do
    so.
    
    Another advantage is that we can now run all the linting tools, even if
    an earlier one failed. As long as one step fails, the overall status is
    still a failure.
    
    In the process, we can remove a `# type: ignore` from lddtree.py;
    argcomplete has typing info. So does pyelftools, but only in git master.
    eli-schwartz committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    5c1444c View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. github: specify minimum python versions for lint checks

    This verifies that lddtree.py etc. do not have any detectable lint
    violations that are specific to only certain versions of python.
    
    We use python 3.7 here, since that is the oldest version that mypy
    supports.
    eli-schwartz committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    57d5d2b View commit details
    Browse the repository at this point in the history