Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-physics/sherpa: new package, add 3.0.0_beta1, 9999 #1279

Closed
wants to merge 2 commits into from

Conversation

APN-Pucky
Copy link
Contributor

No description provided.

@APN-Pucky APN-Pucky force-pushed the pkgpr_master_1719492942 branch from 7c14dcb to 64fd697 Compare June 27, 2024 13:02
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
@APN-Pucky APN-Pucky force-pushed the pkgpr_master_1719492942 branch from 64fd697 to 06f4833 Compare June 27, 2024 13:03
Copy link
Member

@Nowa-Ammerlaan Nowa-Ammerlaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Maybe it makes sense to test these against python3.13 now so it doesn't have to be done later.

@APN-Pucky
Copy link
Contributor Author

APN-Pucky commented Jun 27, 2024

Looks good to me.

Maybe it makes sense to test these against python3.13 now so it doesn't have to be done later.

I don't have py3.13 yet (compiling...). Does it make sense to test it on the beta py3.13 releases? I'd think waiting for the first non-beta release is better for testing the (these uncommon) packages.

@Nowa-Ammerlaan
Copy link
Member

Looks good to me.

Maybe it makes sense to test these against python3.13 now so it doesn't have to be done later.

I don't have py3.13 yet (compiling...). Does it make sense to test it on the beta py3.13 releases? I'd think waiting for the first non-beta release is better for testing the (these uncommon) packages.

The beta should not change functionality wise any more, but I don't mind postponing till the proper release if you prefer.

Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants