Bump and add scikit-hep packages and enable py3.13 #1292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APN-Pucky
changed the title
dev-python/asdf-transform-schemas/asdf-transform-schemas-0.5.0.ebuild
Outdated
Show resolved
Hide resolved
Comment on lines
24
to
26
| BDEPEND=" | ||
| ${RDEPEND} | ||
| dev-python/hatch-vcs[${PYTHON_USEDEP}] | ||
| " |
There was a problem hiding this comment.
Are the RDEPENDs really BDEPENDs here? Probably this should be DEPEND=RDEPEND instead.
Comment on lines
26
to
28
| BDEPEND=" | ||
| ${RDEPEND} | ||
| " |
There was a problem hiding this comment.
Thanks, I'll review the *DEPENDs.
There was a problem hiding this comment.
Since they are (mostly) 100% python packages (No C code or dependencies), I followed https://projects.gentoo.org/python/guide/basic.html#dependencies-in-python-packages and just put them as RDEPEND. I tested that they still build, by uninstalling the RDEPENDs and then run ebuild ... install.
Nowa-Ammerlaan
approved these changes
Oct 21, 2024
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Co-authored-by: Nowa Ammerlaan <andrewammerlaan@gentoo.org> Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
APN-Pucky
force-pushed
the
bump_scikithep
branch
from
edb5859 to
fb8296a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New packages are
and pulled in from updated asdf
All ebuilds here are for at least
python3_{11..13}(exceptmplhepwhere I wait for https://bugs.gentoo.org/941848). Nothing requires a review IMO, but I will wait for possible comments before merging all of it. Some commits shall still be merged to make it all a bit nicer (drop py3.10/metadata).One question:
There is a scikit-hep package that groups all their packages: https://github.com/scikit-hep/scikit-hep/blob/main/requirements.txt but versioned by YYYY-MM-DD with ~fixed versions. I do not want to keep track with all their monthly versioning, nor do I like to fix the versions. What would be the best Gentoo way to handle this? Maybe a loose
virtual/scikit-hep-0that pulls them all without caring about the version. If there is no nice solution I do not mind not offering that collection-package.