Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails v7.2 - Upgrade blocked by devise_invitable #95

Open
ewlarson opened this issue Oct 8, 2024 · 0 comments
Open

Rails v7.2 - Upgrade blocked by devise_invitable #95

ewlarson opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ewlarson
Copy link
Contributor

ewlarson commented Oct 8, 2024 •
edited
Loading

Thought supporting Rails v7.2 would be straight-forward, but devise_invitable causes errors...

/Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/actionmailer-7.2.1/lib/action_mailer/base.rb:632:in `method_missing': undefined method `preview_path=' for class ActionMailer::Base (NoMethodError)
Did you mean?  preview_paths=
               _view_paths=
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/actionmailer-7.2.1/lib/action_mailer/railtie.rb:62:in `block (3 levels) in <class:Railtie>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/actionmailer-7.2.1/lib/action_mailer/railtie.rb:62:in `each'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/actionmailer-7.2.1/lib/action_mailer/railtie.rb:62:in `block (2 levels) in <class:Railtie>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/lazy_load_hooks.rb:97:in `class_eval'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/lazy_load_hooks.rb:97:in `block in execute_hook'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/lazy_load_hooks.rb:87:in `with_execution_control'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/lazy_load_hooks.rb:92:in `execute_hook'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/lazy_load_hooks.rb:78:in `block in run_load_hooks'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/lazy_load_hooks.rb:77:in `each'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/lazy_load_hooks.rb:77:in `run_load_hooks'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/actionmailer-7.2.1/lib/action_mailer/base.rb:1074:in `<class:Base>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/actionmailer-7.2.1/lib/action_mailer/base.rb:476:in `<module:ActionMailer>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/actionmailer-7.2.1/lib/action_mailer/base.rb:12:in `<top (required)>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/zeitwerk-2.6.18/lib/zeitwerk/kernel.rb:34:in `require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/inflector/methods.rb:290:in `const_get'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/inflector/methods.rb:290:in `constantize'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/core_ext/string/inflections.rb:74:in `constantize'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/devise-4.9.4/app/mailers/devise/mailer.rb:4:in `<top (required)>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/zeitwerk-2.6.18/lib/zeitwerk/kernel.rb:26:in `require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/inflector/methods.rb:290:in `const_get'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/inflector/methods.rb:290:in `constantize'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/core_ext/string/inflections.rb:74:in `constantize'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/devise-4.9.4/lib/devise.rb:327:in `get'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/devise-4.9.4/lib/devise.rb:350:in `mailer'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/devise_invitable-2.0.9/lib/devise_invitable/rails.rb:12:in `block in <class:Engine>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:407:in `instance_exec'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:407:in `block in make_lambda'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:179:in `block in call'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:668:in `block (2 levels) in default_terminator'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:667:in `catch'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:667:in `block in default_terminator'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:180:in `call'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:559:in `block in invoke_before'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:559:in `each'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:559:in `invoke_before'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:109:in `run_callbacks'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/reloader.rb:96:in `prepare!'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/application/finisher.rb:74:in `block in <module:Finisher>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/initializable.rb:32:in `instance_exec'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/initializable.rb:32:in `run'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/initializable.rb:61:in `block in run_initializers'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:231:in `block in tsort_each'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:353:in `block (2 levels) in each_strongly_connected_component'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:434:in `each_strongly_connected_component_from'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:352:in `block in each_strongly_connected_component'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:350:in `each'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:350:in `call'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:350:in `each_strongly_connected_component'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:229:in `tsort_each'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/tsort.rb:208:in `tsort_each'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/initializable.rb:60:in `run_initializers'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/application.rb:435:in `initialize!'
	from /Users/ewlarson/Rails/geoblacklight_admin/.internal_test_app/config/environment.rb:5:in `<top (required)>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/zeitwerk-2.6.18/lib/zeitwerk/kernel.rb:34:in `require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/application.rb:411:in `require_environment!'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/command/actions.rb:20:in `boot_application!'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/commands/generate/generate_command.rb:10:in `help'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/commands/generate/generate_command.rb:19:in `perform'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/command.rb:28:in `run'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/command/base.rb:178:in `invoke_command'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor.rb:538:in `dispatch'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/command/base.rb:73:in `perform'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/command.rb:71:in `block in invoke'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/command.rb:149:in `with_argv'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/command.rb:69:in `invoke'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/railties-7.2.1/lib/rails/commands.rb:18:in `<top (required)>'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `require'
	from /Users/ewlarson/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75:in `block (2 levels) in replace_require'
	from bin/rails:4:in `<main>'
rake aborted!
EngineCart failed on with: pid 23057 exit 1
@ewlarson ewlarson added the bug Something isn't working label Oct 8, 2024
ewlarson added a commit that referenced this issue Oct 9, 2024
@ewlarson
Gems: drop devise_invitable
19aab94 
This gem is blocking our Rails v7.2 upgrade path with an error that only appears when adding this gem via Rails Engine generator scripts.

Will document how to add this gem post-GBL Admin install as a local customization option.

Addresses #95
ewlarson added a commit that referenced this issue Oct 9, 2024
@ewlarson
Rails v7.2 support (#97)
48eab8e 
* Gems: drop devise_invitable

This gem is blocking our Rails v7.2 upgrade path with an error that only appears when adding this gem via Rails Engine generator scripts.

Will document how to add this gem post-GBL Admin install as a local customization option.

Addresses #95

* Update test_helper.rb

Fix path for Rails 7.2

* Docs: update for new tasks

* Gems: add mocha

Mock these background jobs. We don't want to really run them, just check that they can be run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ewlarson