Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Rework #1073

Merged
merged 62 commits into from
Sep 10, 2024
Merged

Settings Rework #1073

merged 62 commits into from
Sep 10, 2024

Conversation

HJfod
Copy link
Member

@HJfod HJfod commented Sep 10, 2024

Reworks settings, with the following changes:

  • New title type for creating collapsible titles
  • Split path type into file and folder types
  • Deprecate custom type, add ability for mods to add proper custom types via the custom:type-name syntax
  • Settings have been simplified into a single SettingV3 class, which handles all the base properties like name and description
  • Settings are now PIMPL'd in the new classes
  • The SettingValueSetter class has been replaced with SettingTypeForValueType
  • Old settings system is now deprecated, though is still fully backwards-compatibly API and ABI usable as SettingV3 is automatically translated back into the old system on request

This branch also has a bunch of other changes, all mentioned in the changelog.

@HJfod HJfod merged commit 67814ec into main Sep 10, 2024
11 checks passed
@HJfod HJfod deleted the settings branch September 10, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant