Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging internals #386

Merged
merged 10 commits into from
Dec 30, 2023
Merged

Refactor logging internals #386

merged 10 commits into from
Dec 30, 2023

Conversation

matcool
Copy link
Member

@matcool matcool commented Dec 25, 2023

Fixes #369

  • removes LogComponents, now logs just get formatted into a string and saved like that
  • Now to define formatting of own type, use fmtlib's api (either format_as or fmt::formatter, see their docs!)
  • Breaks ABI (wowie!)
  • Usage wise, your code stays the exact same. unless you had defined your own parser overload

TODO

  • Refactor Logger class?
  • Make Log pimpl? was made hidden instead

@matcool matcool added this to the 2.0.0 milestone Dec 25, 2023
@matcool matcool marked this pull request as draft December 25, 2023 18:23
@matcool matcool self-assigned this Dec 26, 2023
@matcool matcool marked this pull request as ready for review December 28, 2023 23:02
@matcool
Copy link
Member Author

matcool commented Dec 29, 2023

The log file names and msgs aren't using the local time (its always displaying utc time), i couldnt figure it out in time

@matcool
Copy link
Member Author

matcool commented Dec 29, 2023

Fixed now, along with formatting Mod*, so everything should be done now :-)

@matcool matcool merged commit 2ba8761 into main Dec 30, 2023
7 checks passed
@matcool matcool deleted the refactor-log branch December 30, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor logging system
1 participant