Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thesaurus / Date improvements. #8392

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Thesaurus / Date improvements. #8392

wants to merge 2 commits into from

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented Sep 30, 2024

https://github.com/geonetwork/core-geonetwork/pull/6972/files#diff-c7548d94bdb4268915f50f66df5a90f1f7868e4fb1de2f3d2938397e202aaf2fR1057 added month and year format support. This was resolving thesaurus date to the last matching format ie. 1st January for the default date.

This can be tested using regions thesaurus which will contains 2 dates for the thesaurus block.

#6972 adds retrieval of dct:issued|modified|created dates but multiple dates could be added more than one time with same date type code. Improve the mapping (and add more flexibility to customize date type code).

@wangf1122, @ianwallen if you could review to check if the grouping of various dates match your requirements?

Misc:

  • Cleanup namespace so that they are added to the top of the XML response.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Service Public de Wallonie

https://github.com/geonetwork/core-geonetwork/pull/6972/files#diff-c7548d94bdb4268915f50f66df5a90f1f7868e4fb1de2f3d2938397e202aaf2fR1057
added month and year format support. This was resolving thesaurus date
to the last matching format ie. 1st January for the default date.

This can be tested using regions thesaurus which will contains 2 dates
for the thesaurus block.
#6972 adds retrieval of `dct:issued|modified|created` dates but multiple dates could be added more than one time with same date type code. Improve the mapping.
Copy link

sonarcloud bot commented Sep 30, 2024

@fxprunayre
Copy link
Member Author

Also I'm not sure what we should do if a thesaurus has no date defined?

@wangf1122
Copy link
Collaborator

@fxprunayre

I have cherry picked your commit to our system with HNAP schema. No impact. and looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants