-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata editor / validation report improvements #8395
Metadata editor / validation report improvements #8395
Conversation
- Update buttons to display success and errors to use text instead of an icon. - Add style to display the display buttons greyed when the related rules are not displayed. - Show separate messages for success and errors. - If not success or errors reported don't show the expander to show the results in the validation rules. - Group the success and error messages.
@josegar74 It looks good, more clear and simple. One thing I noticed, the expander was still there, although there were no errors. |
Thanks @MichelGabriel I'll check to fix that |
- Fix the display of the expander. - Improve the a bit the layout of the error / success messages. - Improve the tooltips for the buttons to hide / show the messages.
@MichelGabriel I've pushed a change to fix the expander and also improve the a bit the layout of the error / success messages and the tooltips for the buttons to hide / show the messages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expander is now hidden when there are no messages, and the rest is tested and works fine. Thanks.
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.2.x 4.2.x
# Navigate to the new working tree
cd .worktrees/backport-4.2.x
# Create a new branch
git switch --create backport-8395-to-4.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 2323b0a89084241f901e8f71357b4ba8f79b8322,9b12031edb7e38c42830d25bfdbdb105e4eb5f5d
# Push it to GitHub
git push --set-upstream origin backport-8395-to-4.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.2.x Then, create a pull request where the |
* Metadata editor / validation report improvements: - Update buttons to display success and errors to use text instead of an icon. - Add style to display the display buttons greyed when the related rules are not displayed. - Show separate messages for success and errors. - If not success or errors reported don't show the expander to show the results in the validation rules. - Group the success and error messages. * Metadata editor / validation report improvements: - Fix the display of the expander. - Improve the a bit the layout of the error / success messages. - Improve the tooltips for the buttons to hide / show the messages.
* Metadata editor / validation report improvements: - Update buttons to display success and errors to use text instead of an icon. - Add style to display the display buttons greyed when the related rules are not displayed. - Show separate messages for success and errors. - If not success or errors reported don't show the expander to show the results in the validation rules. - Group the success and error messages. * Metadata editor / validation report improvements: - Fix the display of the expander. - Improve the a bit the layout of the error / success messages. - Improve the tooltips for the buttons to hide / show the messages.
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation