Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed spurious whitespace for gn-comma-list #8398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed spurious whitespace for gn-comma-list #8398

wants to merge 1 commit into from
+14 −4

Conversation

joachimnielandt
Copy link
Collaborator

The listing of CRS values was showing a spurious space, originating in the use of inline list items. The solution we implemented makes use of CSS where the whitespace elements are given zero space, while not touching the other element within the list items. This also updates any occurrence of the css class where there's bare text nodes included in the list items.

before
image

after
image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joachimnielandt