-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document WAR configuration option for maxUploadSize #8424
base: main
Are you sure you want to change the base?
Conversation
By default, the maximum file size is set to 100Mb. This limit is set in `/services/src/main/resources/config-spring-geonetwork.xml` with the parameter `maxUploadSize`. | ||
By default, the maximum file size for attachment uploads is set to 100Mb. When building GeoNetwork from source, this limit can be changed in `/services/src/main/resources/config-spring-geonetwork.xml` with the parameter `maxUploadSize`. | ||
|
||
For deployment on an application server, or for adjusting the limit in an already running web application, the value for `maxUploadSize` can be changed in `WEB-INF/config.xml` accordingly: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct, this value is used for the old Jeeves MVC services, while the /services/src/main/resources/config-spring-geonetwork.xml
value is used for Spring MVC services.
It is not clear to me if we still have Jeeves MVC services for file uploads or they have all been migrated to Spring MVC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just worked on the following PR #8427 where I tested the file upload size error handling so I changed the upload size several times during testing and I would set it by adding the following option to the CATALINA_OPTS on application startup.
-Dapi.params.maxUploadSize=1000000000
The value is in bytes. So this sample sets the upload size to 1GB.
That value is used here
<property name="maxUploadSize" value="\${api.params.maxUploadSize}"/> |
And seems to default to default to 100 MB.
api.params.maxUploadSize=100000000 |
I believe the maxUploadSize specified by Jeeves may be used for something else? I have not tested that value so I'm not sure where it is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianwallen for your clarification. I should have taken a more thorough look into the current configuration possibilities. I will revert my misleading lines in the proposed commit and instead just include one sentence on how you suggested to configure the maxUploadSize
during application deployment.
b3ed97d
to
6d9072f
Compare
In case you want to update
maxUploadSize
for an already deployed WAR or prior to deploying.This is meant to replace the obsolete PR Adds WAR configuration option for maxUploadSize from the archived
geonetwork/doc
repository.Checklist
main
branch, backports managed with labelAPI Changes are identified in commit messagesTesting provided for features or enhancements using automatic testsBuild documentation provided for development instructions inREADME.md
filesLibrary management usingpom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation