Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvester / Simple URL / Fix multiple URL alignement #8432

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

fxprunayre
Copy link
Member

Cleanup records to remove, only once all URL are processed. No need for the Element to be preserved, alignement only require the list of UUIDs.

eg. test can be done with the following

{"@id":"335518229","@type":"simpleurl","owner":["1"],"ownerGroup":["4"],"ownerUser":["undefined"],"site":{"name":"pangea","uuid":"44563ecf-4747-4f9b-826c-aafb26e7a5d2","account":{"use":false,"username":[],"password":[]},"url":"https://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820342&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820377&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820377&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820378&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820380&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820381&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820382&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820383&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820384&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820385&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820386&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820387&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820388&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820389&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820390&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820391&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820392&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820393&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820394&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820395&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820396&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820397&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820398&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820399&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820400&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820401&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820402&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820403&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820404&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820405&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820406&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820407&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820408&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820408&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820410&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820411&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820412&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820413&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820414&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820415&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820416&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820417&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820420&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820420&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820421&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820422&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820423&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820424&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820425&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820426&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820427&metadataPrefix=iso19139\nhttps://ws.pangaea.de/oai/provider?verb=GetRecord&identifier=oai:pangaea.de:doi:10.1594/PANGAEA.820428&metadataPrefix=iso19139","icon":"blank.png","loopElement":".//*[local-name() = 'MD_Metadata']","numberOfRecordPath":[],"recordIdPath":"gmd:fileIdentifier/*/text()","pageSizeParam":[],"pageFromParam":[],"toISOConversion":[]},"content":{"validate":"NOVALIDATION","importxslt":"none","batchEdits":"[]","translateContent":false,"translateContentLangs":"","translateContentFields":[]},"options":{"every":"0 0 0 ? * *","oneRunOnly":false,"overrideUuid":"SKIP","status":"active"},"privileges":[{"@id":"1","operation":[{"@name":"view"},{"@name":"dynamic"},{"@name":"download"}]}],"ifRecordExistAppendPrivileges":false,"info":{"lastRun":"2024-10-15T05:13:59.329051Z","running":false,"result":{"added":"46","atomicDatasetRecords":"0","badFormat":"0","collectionDatasetRecords":"0","datasetUuidExist":"1","privilegesAppendedOnExistingRecord":"0","doesNotValidate":"0","xpathFilterExcluded":"0","duplicatedResource":"0","fragmentsMatched":"0","fragmentsReturned":"0","fragmentsUnknownSchema":"0","incompatible":"0","recordsBuilt":"0","recordsUpdated":"0","removed":"0","serviceRecords":"0","subtemplatesAdded":"0","subtemplatesRemoved":"0","subtemplatesUpdated":"0","total":"52","unchanged":"0","unknownSchema":"0","unretrievable":"0","updated":"5","thumbnails":"0","thumbnailsFailed":"0"}}}

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Ifremer

Cleanup records to remove, only once all URL are processed. No need for the Element to be preserved, alignement only require the list of UUIds.
@fxprunayre fxprunayre added this to the 4.4.6 milestone Oct 15, 2024
Copy link

sonarcloud bot commented Oct 15, 2024

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

Tested and looks good also.

@fxprunayre fxprunayre merged commit 5ef4f51 into main Oct 16, 2024
10 checks passed
@fxprunayre fxprunayre deleted the features/446-simpleurlmultipleurlmode branch October 16, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants