Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webcomponent / Use relative path to load main template from cache. #8503

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Webcomponent / Use relative path to load main template from cache. #8503

wants to merge 3 commits into from

Conversation

fxprunayre
Copy link
Member

index.html default view template can be loaded from the Angular template cache directly. If not, webcomponent can failed to load the template due to gnMapServicesCache.getMapservice when base URL does not match GeoNetwork URL.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Ifremer

@fxprunayre
Webcomponent / Use relative path to load main template from cache.
4793fd1 
index.html default view template can be loaded from the Angular template cache directly.
If not, webcomponent can failed to load the template due to
gnMapServicesCache.getMapservice.
@fxprunayre fxprunayre added this to the 4.4.7 milestone Nov 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josegar74 josegar74 Awaiting requested review from josegar74

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.7
Development

Successfully merging this pull request may close these issues.
1 participant
@fxprunayre