-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README.md instructions and test build environment #142
Conversation
I'm not sure if this is needed at all. I think language files are pushed to Transifex using |
They are if we want to continue to have transifex synchronized on english PO files. BUT, from my point of view, this approach has some issues: a) Changing a letter in an english line of the doc will reset all existing translations eg. @archaeogeek improved a lot the english version during the November sprint those changes will be updated by this PR and the transifex key will no longer exist and as a result, all the translation work made by translator will be lost. b) Working on a per line basis does not sound the easiest to work on - translating the full page with figures would make it more usable? c) ...? So what are the options?
|
|
Both ways are horrible! I would contribute to use what we have now and rescue translations when the English test changes. The trouble with using GitHub to manage both translations as independent rst files is there is no way to catch these kind of small changes (or even very large ones.) The percentage translated is very useful at identifying that change has occurred. -1 for me |
Sphinx has an option to add an uuid to the message string. I don't know if that could help here:
|
That is really interesting, I would like to try the procedure outlined by read-the-docs that makes use of this setting. This is in keeping with do not use English lines as a key and continue to use transifex. |
Can you remote the |
I believe I generated them:
I would be happy to have a breakout chat with @fxprunayre as this should resolve his concern ... I do wish this build was faster :) |
If you tested it and it works fine, super, then go for it. |
@fxprunayre I think we need to review the workflow above: https://docs.readthedocs.io/en/stable/guides/manage-translations.html My understanding is this approach (pot files in github) are not something we can test in isolation, it must be made available to Transifex first. Please note that this is just a community acitivity (the website was down and I tried to help) and I have no budget committed to this activity. |
Talking with @juanluisrp, he recommends trying a small project first in the doc folder just to see how UUIDs work. For now I am will remove all the POT changes so this PR can stay focued on a small change to the build system. |
This was created when the website was unavaialble and is part of moving instructions to README.md files as outlined in core-geonetwork/README.md Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
af1a22e
to
9c7eed0
Compare
I have been testing the option of adding uuids, but it doesnt seem to solve the problem. Even with uuids, if the original string changes, it will appear as a new string with no translation in transifex, so transifex doesnt seem to be able to link this new string to the translations available for the old one. The uuids are not even constant for the same translation message, and they change each time the doctree is built. Calling Sphinx to generate the Searching a bit, this seems to be a common problem with no easy solution other than manually "re-linking", new strings with the existing translations for older ones. according to the documentation, the I will investigate this last option a bit more. |
With respect to:
That is surprising, I understood that these UUIDs had some summery of the content that was more stable (not less) over builds and "untangled" by the Transifex website to help keep translations across changes. |
I update what I wrote above: Sphinx seems to be smart enough to detect those small changes in the original strings, and keep the associated translated strings. That happens even if no uuids are added. Creating the pot files from the docs using I wasnt able to integrate this with Transifex, though. Pushing changes was not working, since I could push the pot files (which caused the removal of previous translations when the original strings had changed), but pushing the translated po files was not working for some reason. The transifex-github integration was also not working, but I had never used it before so I am not completely sure that it was not my fault. |
I think you have to pay, or get permission as an open source project like geonetwork has done. |
The approach outlined in this PR is fine, it relies on transifex web client being used for translations so it can make suggestions based on previous translation that are close (even if the key changes). |
There is no interest in pursuing this PR. |
During the course of testing I found that transifix no longer autoupdates, reported as #141