Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add a type argument to ImageGallery so that we can use whatever props we want for ImageObject #19

Open
nathantew14 opened this issue Sep 1, 2023 · 0 comments

Comments

@nathantew14
Copy link

When rendering custom components with renderCustomImage and the other similar render props, I often want to pass in additional data for the custom component to work, beyond just showing the image. For example, showing a button conditionally. It still works as long as the objects passed to the images props have the properties I want, but typescript complains:

Property 'createdBy' does not exist on type 'ImageObject'.

I tried to do it myself to make a PR, but unfortunately I'm still too newb at typescript...

If this isn't added by the time I figure it out, I'll make a PR for it :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant