deprecate quick_collection, simplify docs #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/deprecate-quick-collection
branch
from
1dbc735
to
8cea2e1
Compare
lnicola
approved these changes
Jan 6, 2023
|
bors d+ (needs rebase) |
|
✌️ michaelkirk can now approve this pull request. To approve and merge a pull request, simply reply with |
michaelkirk
force-pushed
the
mkirk/deprecate-quick-collection
branch
from
8cea2e1
to
f691656
Compare
|
Sorry that I didn't merge this a long time ago! I've made a couple minor changes but the thrust is the same. Can I get another review? |
michaelkirk
force-pushed
the
mkirk/deprecate-quick-collection
branch
from
f691656
to
cd43330
Compare
urschrei
approved these changes
Jun 27, 2024
michaelkirk
force-pushed
the
mkirk/deprecate-quick-collection
branch
from
443c5c0
to
e9c419b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.The real motivation for this pull request, is that I was trying to look up some basic usage of the geojson crate and it took me uncomfortably long. Our documentation has grown over time and become a bit long winded in my experience.
So I was looking for ways to simplify our documentation, and noticed the couple paragraphs devoted to
quick_collection.Since
quick_collectionconverts&GeoJson -> Result<geo_types::GeometryCollection>, I think it will be more discoverable under the idiomaticTryFromtrait, and because it's working like the idiomaticTryFromtrait, I think we can truncate some of the documentation.