Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: parse points without heap allocation #223

Draft
wants to merge 28 commits into
base: mkirk/tiny-vec
Choose a base branch
from
Draft

WIP: parse points without heap allocation #223

wants to merge 28 commits into from

Commits on Jul 13, 2023

  1. spike on tinyvec

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f0b72a2 View commit details
    Browse the repository at this point in the history

  2. Position as opaque struct 

    tiny_vec becomes private implementation detail in case we want to change
it further in the future.

It's admittedly more verbose with this commit. We could clean it up with
a pos! macro, or add some helper methods like Value::pt2d([1, 2]).
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    9778880 View commit details
    Browse the repository at this point in the history

  3. BREAKING: address geo deprecations

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a9d1f0e View commit details
    Browse the repository at this point in the history

  4. wip: parse points on stack

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6de1b4c View commit details
    Browse the repository at this point in the history

  5. wip: FeatureIterator not from json value

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2ecceeb View commit details
    Browse the repository at this point in the history

  6. DO NOT MERGE: added pretty_env_logger for debugging

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    50aa2fb View commit details
    Browse the repository at this point in the history

  7. wip: deserializes geometry w/o JsonObject, but temporarily Ive broken… 

    … custom struct deserialization
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fa89704 View commit details
    Browse the repository at this point in the history

  8. add test and make Id ser/de

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    db625f9 View commit details
    Browse the repository at this point in the history

  9. try to use derived ser/de

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6ef83b0 View commit details
    Browse the repository at this point in the history

  10. maybe dont merge... trying to see if the tagging is hurting my perf

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fa882c4 View commit details
    Browse the repository at this point in the history

  11. WIP: CoordField visitor

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3980aab View commit details
    Browse the repository at this point in the history

  12. wip: the countries parse is now a little faster than tiny_vec! But ho… 

    …nestly not that much =/
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    356b4cf View commit details
    Browse the repository at this point in the history

  13. disable custom serialization benches for now

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    5978430 View commit details
    Browse the repository at this point in the history

  14. formatting?

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7490611 View commit details
    Browse the repository at this point in the history

  15. fixup

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    840ea37 View commit details
    Browse the repository at this point in the history

  16. fix geometrycollection 

    test result: FAILED. 50 passed; 29 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1031b26 View commit details
    Browse the repository at this point in the history

  17. fix point geometry 

    test result: FAILED. 58 passed; 21 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2aa6856 View commit details
    Browse the repository at this point in the history

  18. Geometry type is not "Geometry", so this cannot be considered "tagged" 

    I'm not sure of the mechanics of how this works, but some preliminary
measurements don't show a big perf difference.

Note the changes to feature_collections.rs are immaterial - only
deleting some vestigial code.
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    98f6693 View commit details
    Browse the repository at this point in the history

  19. notes and cleanup

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    bc21f44 View commit details
    Browse the repository at this point in the history

  20. tagging top level geometry

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f0b6201 View commit details
    Browse the repository at this point in the history

  21. remove redundant logger

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7b1570f View commit details
    Browse the repository at this point in the history

  22. geometry field is optional for Feature

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a8708a0 View commit details
    Browse the repository at this point in the history

  23. better debug output

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4096bb2 View commit details
    Browse the repository at this point in the history

  24. NBD: format as guard 

    test result: FAILED. 63 passed; 16 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    36d237a View commit details
    Browse the repository at this point in the history

  25. "type" is consumed by outer deserializer 

    test result: FAILED. 69 passed; 10 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.07s
    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    9d41e27 View commit details
    Browse the repository at this point in the history

  26. properties are optional

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    83036d6 View commit details
    Browse the repository at this point in the history

  27. accumulate foreign_members on feature collection

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    be9f602 View commit details
    Browse the repository at this point in the history

  28. expect different error

    @michaelkirk
    michaelkirk committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    bbff616 View commit details
    Browse the repository at this point in the history