Improve scaling code a bit #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On a second though, I think `to_mvt_unscaled` is more accurate. `raw` here would be confusing. * There is no need to store bounds and do additional math ops on it. Can precompute a few things earlier on. * Default can be auto-derived
|
P.S. Once you +1 this (or merge it into your branch), i can +1/merge yours into main |
pka
approved these changes
Aug 8, 2023
nyurik
added a commit
that referenced
this pull request
Aug 9, 2023
* On a second though, I think `to_mvt_unscaled` is more accurate. `raw` here would be confusing. * There is no need to store bounds and do additional math ops on it. Can precompute a few things earlier on. * Default can be auto-derived
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_mvt_unscaledis more accurate.rawhere would be confusing.P.S. @pka I think its better to push PRs to individual's forks, and only keep project-maintained versions in the primary repo. This way there would be no experimental branches in the main repo, reducing confusion.