Fix: invalid WKT output for CSV's #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of georust#160, this breaks with invalid output: GEOMETRYCOLLECTION EMPTYPOINT(-122.329051 47.6069),POINT(-122.266529 47.515984)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the fix, the new tests fail with invalid output:
It's because of a hack in my earlier implementation — because we can't know the number of lines in a CSV before reading it, we can't know the size of the output unless we want to double back or hold the entire thing in memory, which I think is undesirable.
Previously I just said the size was "0" sized because the size was only used to optimize runtime performance, but #160 expects the value it's given to be accurate (which is reasonable) in order to produce valid output.
Another approach might be to have
sizebe some kind of enum to explicitly distinguish between known and unknown sizes, but it makes the api less ergonomic for all the other processors which know their size.