Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix esm build & add vitest #354

Closed
wants to merge 7 commits into from
Closed

fix: fix esm build & add vitest #354

wants to merge 7 commits into from

Conversation

hwbllmnn
Copy link
Contributor

Fixes the esm build and gets rid of jest in favour of vitest.

@geostyler/devs Please review.

Copy link
Contributor

@jansule jansule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a question and a minor remark

package.json Outdated
@@ -1,15 +1,11 @@
{
"name": "geostyler-cql-parser",
"version": "3.0.2",
"version": "4.0.0-next.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be part of the main branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is currently published as a pre-release so I can use it for testing with the other repos.

vitest.config.ts Outdated Show resolved Hide resolved
@hwbllmnn
Copy link
Contributor Author

Closing, replaced by #357

@hwbllmnn hwbllmnn closed this Jun 22, 2024
@hwbllmnn hwbllmnn deleted the fix-esm-build branch June 22, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants