Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub icon in night mode #2

Open
sergiks opened this issue Mar 6, 2021 · 1 comment
Open

GitHub icon in night mode #2

sergiks opened this issue Mar 6, 2021 · 1 comment
Labels
add icon Request to add icon(s)

Comments

@sergiks
Copy link

sergiks commented Mar 6, 2021

GitHub icon has the cat as a "hole", should be a shape, filled with light grey.

In "night" GitHub mode the icon is not visible, renders dark on dark background.

@tomchen
Copy link
Member

tomchen commented May 3, 2021

But the cat is a "hole". You can see in browser the white GitHub icon at top left, the background circle is a shape and can change its color when the mouse is over it, but the cat is not part of any shape


For the night mode, yeah I'll probably make a set of night mode icons, that include:

  • manually found and dowloaded night mode icons (take GitHub icon as an example, I'll use the white icon as GitHub icon's night mode version)
  • auto-generated white bg icons as fallback

@tomchen tomchen added the add icon Request to add icon(s) label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add icon Request to add icon(s)
Projects
None yet
Development

No branches or pull requests

2 participants