Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure TX fee split of DLC channels #18

Merged
merged 2 commits into from
May 16, 2024
Merged

Allow to configure TX fee split of DLC channels #18

merged 2 commits into from
May 16, 2024

Conversation

luckysori
Copy link

Done as quick as possible, so probably very bad. I just wanted to see if it could work.

@luckysori luckysori requested review from bonomat and holzeis May 15, 2024 14:46
@luckysori luckysori self-assigned this May 15, 2024
@luckysori luckysori mentioned this pull request May 15, 2024
Merged
holzeis
holzeis approved these changes May 15, 2024
View reviewed changes
Copy link

@holzeis holzeis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough to me. The only thing that I do not like is that the fee_config has to be provided in the on_dlc_message.

I think it would be cleaner to add this to the offer message.

dlc-manager/src/manager.rs Outdated Show resolved Hide resolved
@luckysori
Copy link
Author

Looks simple enough to me. The only thing that I do not like is that the fee_config has to be provided in the on_dlc_message.

I think it would be cleaner to add this to the offer message.

I agree and I've addressed this now.

@luckysori luckysori merged commit 2545d6e into master May 16, 2024
4 of 198 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holzeis holzeis holzeis approved these changes

@bonomat bonomat Awaiting requested review from bonomat

Assignees

@luckysori luckysori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckysori @holzeis