Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It is wrongly mentioned that -60000 sats are incoming although there are no channels waiting to be closed, and also this happens because total balance is less than the spendable balance (hence the -ve sign) which can never be the case
Description
This happens because we remove the ReservedBalance from the TotalBalance in LND which makes TotalBalance less than ConfirmedBalance
From LDK docs
That's why we remove
total_anchor_channels_reserve_sats
fromtotal_onchain_balance_sats
in LDKBut in LND,
spendable_onchain_balance_sats
doesn't remove any reserves, it gives the actual confirmed balance. So this change subtractstotal_anchor_channels_reserve_sats
from both