Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use credenza provider #292

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: use credenza provider #292

merged 1 commit into from
Jul 19, 2024

Conversation

im-adithya
Copy link
Member

Fixes #279

@im-adithya im-adithya requested a review from rolznz July 18, 2024 15:32
rolznz
rolznz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

reneaaron
reneaaron approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tACK.

Maybe the CredenzaProvider can be moved to the Layout at one point. For now it's fine I think.

@reneaaron reneaaron merged commit b72d044 into master Jul 19, 2024
7 of 8 checks passed
@reneaaron reneaaron deleted the task-credenza-bug branch July 19, 2024 07:24
@im-adithya
Copy link
Member Author

Maybe the CredenzaProvider can be moved to the Layout at one point. For now it's fine I think.

Yeah was thinking the same, will fix that in another PR ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron approved these changes

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DialogTrigger error
3 participants
@im-adithya @rolznz @reneaaron